Skip to content

Conversation

@azat
Copy link

@azat azat commented Dec 25, 2023

No description provided.

azat added 14 commits December 24, 2023 22:54
stacktrace:

    thread '<unnamed>' panicked at 'called `Option::unwrap()` on a `None` value', /home/azat/.cargo/git/checkouts/clickhouse-rs-37da3cb97e01332d/afd8ce5/src/io/transport.rs:122:31

       8: core::option::Option<T>::unwrap
                 at /rustc/0ab38e95bb1cbf0bd038d359bdecbfa501f003a7/library/core/src/option.rs:935:21
       9: clickhouse_rs::io::transport::ClickhouseTransport::clear::{{closure}}
                 at /home/azat/.cargo/git/checkouts/clickhouse-rs-37da3cb97e01332d/afd8ce5/src/io/transport.rs:122:29
      10: clickhouse_rs::ClientHandle::ping::{{closure}}::{{closure}}
                 at /home/azat/.cargo/git/checkouts/clickhouse-rs-37da3cb97e01332d/afd8ce5/src/lib.rs:340:59
      11: <tokio::time::timeout::Timeout<T> as core::future::future::Future>::poll
                 at /home/azat/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.34.0/src/time/timeout.rs:202:33
      12: clickhouse_rs::with_timeout::{{closure}}
                 at /home/azat/.cargo/git/checkouts/clickhouse-rs-37da3cb97e01332d/afd8ce5/src/lib.rs:641:43
      13: clickhouse_rs::ClientHandle::ping::{{closure}}
                 at /home/azat/.cargo/git/checkouts/clickhouse-rs-37da3cb97e01332d/afd8ce5/src/lib.rs:365:10
      14: clickhouse_rs::retry_guard::check::{{closure}}
                 at /home/azat/.cargo/git/checkouts/clickhouse-rs-37da3cb97e01332d/afd8ce5/src/retry_guard.rs:57:14
      15: clickhouse_rs::retry_guard::retry_guard::{{closure}}
                 at /home/azat/.cargo/git/checkouts/clickhouse-rs-37da3cb97e01332d/afd8ce5/src/retry_guard.rs:21:33
      16: clickhouse_rs::ClientHandle::check_connection::{{closure}}
                 at /home/azat/.cargo/git/checkouts/clickhouse-rs-37da3cb97e01332d/afd8ce5/src/lib.rs:586:78
      17: clickhouse_rs::ClientHandle::wrap_stream::{{closure}}
                 at /home/azat/.cargo/git/checkouts/clickhouse-rs-37da3cb97e01332d/afd8ce5/src/lib.rs:555:89
      ...
      26: clickhouse_rs::with_timeout::{{closure}}
                 at /home/azat/.cargo/git/checkouts/clickhouse-rs-37da3cb97e01332d/afd8ce5/src/lib.rs:641:43
      27: clickhouse_rs::types::query_result::QueryResult::fetch_all::{{closure}}
                 at /home/azat/.cargo/git/checkouts/clickhouse-rs-37da3cb97e01332d/afd8ce5/src/types/query_result/mod.rs:47:10
"services" cannot be used right now because now container depends on the
repository already checkedout, while this is not true for "services".

Fix this by manually starting docker as a separate step.
CI reports [1]:

    ---- pool::test::test_many_connection stdout ----
    thread 'pool::test::test_many_connection' panicked at src/pool/mod.rs:380:9:
    assertion failed: spent < Duration::from_millis(2500)

  [1]: https://github.com/azat-rust/clickhouse-rs/actions/runs/7323232432/job/19945622315?pr=1
suharev7 and others added 4 commits March 31, 2024 20:34
Fix possible panic in case broken protocol
Add ability to use rustls over native-tls
Previously ClickhouseTransport::poll_next did not tries to process
packets if the server closed the connection, however there can be some
packet (likely Exception), that we need to pass to user.

Also this will avoid panic in case of missing Hello packet, i.e. in
case of credentials mismatch.
azat added 3 commits April 15, 2025 23:06
* fix-panic-on-hello:
  ci: set CLICKHOUSE_SKIP_USER_SETUP to avoid restricting default user
  Fix test_size_of expectation (the size should be 64 with alignment)
  Properly handle terminated connection by the server
  Ensure that Hello packet correctly received
azat added 11 commits April 19, 2025 17:57
* mTLS-upstream:
  Revert "ci: temporary enable CI for next branch"
  Update README about TLS features
  Refactor mTLS support
  Add mTLS support for native-tls
  ci: add mTLS
  Implement mTLS for rustls
  Rename certificate to ca_certificate
  ci: generate TLS certificates on the host for client
  Fix CaUsedAsEndEntity error
  Add ability to specify certificate
  Fix typo (s/DER/PEM/)
  ci: temporary enable CI for next branch
  ci: disable fail-fast for matrix (plus it is how it works before)
  ci: simplify TLS jobs
* client-name:
  Add ability to change client name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants